Avoid broken locks in commit processing

Problem/Motivation

On Friday night, I committed a 12 MB diff to the 8.4.x and 8.3.x branches. Shortly thereafter, VCS integration on d.o stopped working. The commits list shows the 8.4.x commit, but not the 8.3.x one:
https://www.drupal.org/node/3060/commits

Currently has at the top:
https://www.drupal.org/commitlog/commit/2/52e3eec616efab4d5201e30d085a09…

Despite all these commits since:

git log --after=52e3eec616 | pbcopy

commit 679614f0165e9f0735c6ba87d99f3f49e63b77d5
Author: xjm <[email protected]>
Date:   Sun Mar 5 06:13:32 2017 -0600

    Issue #2668752 by mr.baileys, chx, tim.plunkett, Berdir: DefaultPluginManager::setCacheBackend has wrong information about language suffix

commit fdbbf4b673f123d1c568cd86a7f261f7129bb2a9
Author: xjm <[email protected]>
Date:   Sat Mar 4 18:08:47 2017 -0600

    Issue #2857780 by vegantriathlete: Correct typo in comment in TagTest.php

commit 59ee98a2626b58ada48810a65e9138d5720e5434
Author: xjm <[email protected]>
Date:   Sat Mar 4 15:09:09 2017 -0600

    Issue #2802663 by mpdonadio, Berdir, jibran, jhedstrom, amateescu: Exceptions due ChangedItem, CreatedItem, and TimestampItem implicit dependencies on datetime module

commit 1324a42f0c1303e889e6567337da6e6d430b71ed
Author: xjm <[email protected]>
Date:   Sat Mar 4 14:07:24 2017 -0600

    Revert "Issue #2802663 by mpdonadio, jibran, Berdir, jhedstrom, amateescu: ChangedItem, CreatedItem, and TimestampItem fields have an implicit dependency on datetime module"
    
    This reverts commit cd176e1d2438e925950fd2d2e256fb8d6c57980f.

commit 9ee87105b9a5fe5ccf771a6af6ef1ff38590c23c
Author: xjm <[email protected]>
Date:   Sat Mar 4 14:01:37 2017 -0600

    Issue #2856364 by drpal, Wim Leers: Reposition Quickedit overlay on toolbar orientation change

commit cd176e1d2438e925950fd2d2e256fb8d6c57980f
Author: xjm <[email protected]>
Date:   Sat Mar 4 13:52:45 2017 -0600

    Issue #2802663 by mpdonadio, jibran, Berdir, jhedstrom, amateescu: ChangedItem, CreatedItem, and TimestampItem fields have an implicit dependency on datetime module

commit fa39f06433eebd7f2b52bc48a33a7fba05d6f150
Author: xjm <[email protected]>
Date:   Sat Mar 4 12:42:17 2017 -0600

    Issue #2361539 by alexpott, webflo, AjitS, himanshu-dixit, tameeshb, xjm: Config export key order is not predictable for sequences, add orderby property to config schema

commit 47ec7f7d4f0146e1de578457028fbbf52ff1cfd0
Author: xjm <[email protected]>
Date:   Sat Mar 4 12:27:34 2017 -0600

    Issue #2600836 by balagan, Sagar Ramgade, Chi, anil280988, joshi.rohit100, Jo Fitzgerald, vaplas, dawehner, alexpott, klausi: Make protected Simpletest test methods public for consistency

commit cd8aa44faea8c0d067664740b042be49da80e86b
Author: xjm <[email protected]>
Date:   Sat Mar 4 12:06:48 2017 -0600

    Issue #2845731 by ashish-deynap, vaplas, chiranjeeb2410, Munavijayalakshmi, tramsaal, xjm: Theming guide links are wrong

commit 91f0f7b1268d569fc69f4ed07c2da26d5778f07e
Author: xjm <[email protected]>
Date:   Sat Mar 4 09:20:03 2017 -0600

    Issue #2857410 by tim.plunkett, DamienMcKenna: Adding a page-level #prefix or #suffix causes it to be output twice on one-col layout

commit f621a88dd0bb760c74142125cda9056b3afd1ce8
Author: xjm <[email protected]>
Date:   Sat Mar 4 09:04:49 2017 -0600

    Issue #2857714 by klausi: Upgrade Coder to 8.2.11

commit 72d65cc85cd3a71526f703ca480a2aae14fb65dc
Author: xjm <[email protected]>
Date:   Sat Mar 4 08:02:01 2017 -0600

    Issue #2857822 by alexpott, klausi: Fix coding standards issues introduced mostly by array syntax conversion

commit 52e3eec616efab4d5201e30d085a09ba5c4817e6
Author: xjm <[email protected]>
Date:   Fri Mar 3 19:20:24 2017 -0600

    Issue #2776975 by joelpittet, dawehner, tim.plunkett, xjm, pfrenssen: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase

commit 3aba956a39a4852f42cad8483e4e6e307bedbd0e
Author: Alex Pott <[email protected]>
Date:   Fri Mar 3 16:50:40 2017 +0000

    Issue #2666166 by jsst, Lendude, Andrej Galuf: View with not required relationship and aggregation enabled fails to execute

Additionally, neither that issue nor any other has had an automated commit comment posted since.

I don’t want to just assume that it’s the 12 MB patch, but… Was at the 12 MB patch? Did I break it?

Proposed resolution

?

Remaining tasks

?

FWIW, we have another large coding standards patch on the way (only 1 MB rather than 12): #2854529: Fix Drupal.Scope.MethodScope – all methods should have scopes


Source: https://www.drupal.org/project/issues/rss/infrastructure